Fix typo in examples#41
Closed
lunohodov wants to merge 1 commit intoriverqueue:masterfrom
lunohodov:patch-1
Closed
Fix typo in examples#41lunohodov wants to merge 1 commit intoriverqueue:masterfrom lunohodov:patch-1
lunohodov wants to merge 1 commit intoriverqueue:masterfrom
lunohodov:patch-1
Conversation
Author
|
I just realized this is not a typo and |
Contributor
|
Yeah, it's just a demo set of args for demonstration purposes. "Sort args" takes a set of strings and sorts them in a background job. |
Contributor
|
So turns out you were right in that there was something not quite right in here ... fixed some references in #44. |
Author
|
Thanks for getting to the bottom of this. I was confused to see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The examples in README declare a
SortArgsclass but use one namedSimpleArgs. This PR makes the naming consistent.